lib, arch: add filter argument to show_mem and fix private implementations
authorDavid Rientjes <rientjes@google.com>
Thu, 24 Mar 2011 22:18:15 +0000 (15:18 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 25 Mar 2011 00:49:37 +0000 (17:49 -0700)
commitb2b755b5f10eb32fbdc73a9907c07006b17f714b
tree444c7a93cc6c3dd109a4b23f1f76cdc38cf5eb10
parente285c1746accb80620e511f9c72e9893beeedc0e
lib, arch: add filter argument to show_mem and fix private implementations

Commit ddd588b5dd55 ("oom: suppress nodes that are not allowed from
meminfo on oom kill") moved lib/show_mem.o out of lib/lib.a, which
resulted in build warnings on all architectures that implement their own
versions of show_mem():

lib/lib.a(show_mem.o): In function `show_mem':
show_mem.c:(.text+0x1f4): multiple definition of `show_mem'
arch/sparc/mm/built-in.o:(.text+0xd70): first defined here

The fix is to remove __show_mem() and add its argument to show_mem() in
all implementations to prevent this breakage.

Architectures that implement their own show_mem() actually don't do
anything with the argument yet, but they could be made to filter nodes
that aren't allowed in the current context in the future just like the
generic implementation.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: James Bottomley <James.Bottomley@hansenpartnership.com>
Suggested-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David Rientjes <rientjes@google.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
14 files changed:
arch/arm/mm/init.c
arch/ia64/mm/contig.c
arch/ia64/mm/discontig.c
arch/parisc/mm/init.c
arch/powerpc/xmon/xmon.c
arch/sparc/mm/init_32.c
arch/tile/mm/pgtable.c
arch/unicore32/mm/init.c
drivers/tty/sysrq.c
drivers/tty/vt/keyboard.c
include/linux/mm.h
lib/show_mem.c
mm/oom_kill.c
mm/page_alloc.c