RDMA/rxe: Fix the error "trying to register non-static key in rxe_cleanup_task"
authorZhu Yanjun <yanjun.zhu@linux.dev>
Thu, 13 Apr 2023 10:11:15 +0000 (18:11 +0800)
committerLeon Romanovsky <leon@kernel.org>
Sun, 16 Apr 2023 07:51:33 +0000 (10:51 +0300)
commitb2b1ddc457458fecd1c6f385baa9fbda5f0c63ad
tree3a13af7b677bda7a79ea6f2511cb362a731ab90e
parenta2e20b29cf9ce6d2070a6e36666e2239f7f9625b
RDMA/rxe: Fix the error "trying to register non-static key in rxe_cleanup_task"

In the function rxe_create_qp(), rxe_qp_from_init() is called to
initialize qp, internally things like rxe_init_task are not setup until
rxe_qp_init_req().

If an error occurred before this point then the unwind will call
rxe_cleanup() and eventually to rxe_qp_do_cleanup()/rxe_cleanup_task()
which will oops when trying to access the uninitialized spinlock.

If rxe_init_task is not executed, rxe_cleanup_task will not be called.

Reported-by: syzbot+cfcc1a3c85be15a40cba@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?id=fd85757b74b3eb59f904138486f755f71e090df8
Fixes: 8700e3e7c485 ("Soft RoCE driver")
Fixes: 2d4b21e0a291 ("IB/rxe: Prevent from completer to operate on non valid QP")
Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
Link: https://lore.kernel.org/r/20230413101115.1366068-1-yanjun.zhu@intel.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/sw/rxe/rxe_qp.c