ASoC: codecs: rt711-sdca: simplify set_stream
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 24 Mar 2023 01:44:04 +0000 (09:44 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 29 Mar 2023 14:03:06 +0000 (15:03 +0100)
commitb2790eccc0bc755d37ed5cd8d225cec0d72798c8
tree757e31c4e88f8c2f84a0a1b14e5fbc69585a725c
parentfa55b31fb65347ceab617af7541f0a31b53901f1
ASoC: codecs: rt711-sdca: simplify set_stream

Using a dynamic allocation to store a single pointer is not very
efficient/useful.

Worse, the memory is released in the SoundWire stream.c file, but
still accessed in the DAI shutdown, leading to kmemleak reports.

And last the API requires the previous stream information to be
cleared when the argument is NULL.

Simplify the code to address all 3 problems.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20230324014408.1677505-10-yung-chuan.liao@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt711-sdca.c
sound/soc/codecs/rt711-sdca.h