ext4: set h_journal if there is a failure starting a reserved handle
authorTheodore Ts'o <tytso@mit.edu>
Wed, 18 Apr 2018 15:49:31 +0000 (11:49 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Wed, 18 Apr 2018 15:49:31 +0000 (11:49 -0400)
commitb2569260d55228b617bd82aba6d0db2faeeb4116
tree45069307616ca3dc612cca1425de5a1f0b9647be
parent349fa7d6e1935f49bf4161c4900711b2989180a9
ext4: set h_journal if there is a failure starting a reserved handle

If ext4 tries to start a reserved handle via
jbd2_journal_start_reserved(), and the journal has been aborted, this
can result in a NULL pointer dereference.  This is because the fields
h_journal and h_transaction in the handle structure share the same
memory, via a union, so jbd2_journal_start_reserved() will clear
h_journal before calling start_this_handle().  If this function fails
due to an aborted handle, h_journal will still be NULL, and the call
to jbd2_journal_free_reserved() will pass a NULL journal to
sub_reserve_credits().

This can be reproduced by running "kvm-xfstests -c dioread_nolock
generic/475".

Cc: stable@kernel.org # 3.11
Fixes: 8f7d89f36829b ("jbd2: transaction reservation support")
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Reviewed-by: Jan Kara <jack@suse.cz>
fs/jbd2/transaction.c