[mlir] ExecutionEngine: default enableObjectCache to false
authorEmilio Cota <ecg@google.com>
Wed, 9 Mar 2022 15:08:17 +0000 (10:08 -0500)
committerEmilio Cota <ecg@google.com>
Thu, 10 Mar 2022 16:24:48 +0000 (11:24 -0500)
commitb24de9f6845217f03014a36814d61f4ed91f0405
tree07019d814f43fd8f24d7b60d4257b07580423d32
parentf06d487dd68b6fa103b5ffd072e17e24041f1983
[mlir] ExecutionEngine: default enableObjectCache to false

The enableObjectCache option was added in
https://reviews.llvm.org/rG06e8101034e, defaulting to false. However,
the init code added there got its logic reversed
(cache(enableObjectCache ? nullptr : new SimpleObjectCache()), which was
fixed in https://reviews.llvm.org/rGd1186fcb04 by setting the default to
true, thereby preserving the existing behavior even if it was
unintentional.

Default now the object cache to false as it was originally intended.
While at it, mention in enableObjectCache's documentation how the
cache can be dumped.

Reviewed-by: mehdi_amini
Differential Revision: https://reviews.llvm.org/D121291
mlir/include/mlir/ExecutionEngine/ExecutionEngine.h
mlir/lib/ExecutionEngine/ExecutionEngine.cpp
mlir/lib/ExecutionEngine/JitRunner.cpp