mm: fix memory leak on mm_init error handling
authorMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Thu, 30 Mar 2023 13:38:22 +0000 (09:38 -0400)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 18 Apr 2023 21:22:12 +0000 (14:22 -0700)
commitb20b0368c614c609badfe16fbd113dfb4780acd9
tree5754dd9aa60d6d5f2a8d1c7b1027dd9acae70e7a
parent1007843a91909a4995ee78a538f62d8665705b66
mm: fix memory leak on mm_init error handling

commit f1a7941243c1 ("mm: convert mm's rss stats into percpu_counter")
introduces a memory leak by missing a call to destroy_context() when a
percpu_counter fails to allocate.

Before introducing the per-cpu counter allocations, init_new_context() was
the last call that could fail in mm_init(), and thus there was no need to
ever invoke destroy_context() in the error paths.  Adding the following
percpu counter allocations adds error paths after init_new_context(),
which means its associated destroy_context() needs to be called when
percpu counters fail to allocate.

Link: https://lkml.kernel.org/r/20230330133822.66271-1-mathieu.desnoyers@efficios.com
Fixes: f1a7941243c1 ("mm: convert mm's rss stats into percpu_counter")
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Acked-by: Shakeel Butt <shakeelb@google.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
kernel/fork.c