spi: mediatek: Enable irq before the spi registration
authorRicardo Ribalda <ribalda@chromium.org>
Sun, 25 Dec 2022 08:37:12 +0000 (09:37 +0100)
committerMark Brown <broonie@kernel.org>
Tue, 27 Dec 2022 13:42:40 +0000 (13:42 +0000)
commitb1e9c223736b1471287f0ac46a368676c3bd7727
tree4f0fa253fb18a994ba052a4dd97a2aebc563b9ba
parentce9ef749a2fa9048c1ebacc3194b17a9628512f5
spi: mediatek: Enable irq before the spi registration

If the irq is enabled after the spi si registered, there can be a race
with the initialization of the devices on the spi bus.

Eg:
mtk-spi 1100a000.spi: spi-mem transfer timeout
spi-nor: probe of spi0.0 failed with error -110
Unable to handle kernel NULL pointer dereference at virtual address
0000000000000010
...
Call trace:
 mtk_spi_can_dma+0x0/0x2c

Fixes: c6f7874687f7 ("spi: mediatek: Enable irq when pdata is ready")
Reported-by: Daniel Golle <daniel@makrotopia.org>
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Tested-by: Daniel Golle <daniel@makrotopia.org>
Link: https://lore.kernel.org/r/20221225-mtk-spi-fixes-v1-0-bb6c14c232f8@chromium.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-mt65xx.c