setfacl removes part of ACL when setting POSIX ACLs to Samba
authorSteve French <smfrench@gmail.com>
Sat, 16 Nov 2013 02:41:32 +0000 (20:41 -0600)
committerSteve French <smfrench@gmail.com>
Sat, 16 Nov 2013 02:50:58 +0000 (20:50 -0600)
commitb1d93356427be6f050dc55c86eb019d173700af6
tree70adc3282f8f5fc535aa440f24d5ca695cdc178f
parentde9f68df675e9d8b0b6a533818a79dca6546a7ba
setfacl removes part of ACL when setting POSIX ACLs to Samba

setfacl over cifs mounts can remove the default ACL when setting the
(non-default part of) the ACL and vice versa (we were leaving at 0
rather than setting to -1 the count field for the unaffected
half of the ACL.  For example notice the setfacl removed
the default ACL in this sequence:

steven@steven-GA-970A-DS3:~/cifs-2.6$ getfacl /mnt/test-dir ; setfacl
-m default:user:test:rwx,user:test:rwx /mnt/test-dir
getfacl: Removing leading '/' from absolute path names
user::rwx
group::r-x
other::r-x
default:user::rwx
default:user:test:rwx
default:group::r-x
default:mask::rwx
default:other::r-x

steven@steven-GA-970A-DS3:~/cifs-2.6$ getfacl /mnt/test-dir
getfacl: Removing leading '/' from absolute path names
user::rwx
user:test:rwx
group::r-x
mask::rwx
other::r-x

CC: Stable <stable@kernel.org>
Signed-off-by: Steve French <smfrench@gmail.com>
Acked-by: Jeremy Allison <jra@samba.org>
fs/cifs/cifssmb.c