brcmsmac: fix memory leak in wlc_phy_attach_lcnphy
authorKeita Suzuki <keitasuzuki.park@sslab.ics.keio.ac.jp>
Tue, 8 Sep 2020 12:17:41 +0000 (12:17 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 08:05:45 +0000 (09:05 +0100)
commitb1a1f0d6c57381f929f39ebaaafa38e569631db8
tree9f745c2b19544f24b56da663b3ab745fa951ef87
parenta922694032c1b672ad729e86cf5b1596626f23e3
brcmsmac: fix memory leak in wlc_phy_attach_lcnphy

[ Upstream commit f4443293d741d1776b86ed1dd8c4e4285d0775fc ]

When wlc_phy_txpwr_srom_read_lcnphy fails in wlc_phy_attach_lcnphy,
the allocated pi->u.pi_lcnphy is leaked, since struct brcms_phy will be
freed in the caller function.

Fix this by calling wlc_phy_detach_lcnphy in the error handler of
wlc_phy_txpwr_srom_read_lcnphy before returning.

Signed-off-by: Keita Suzuki <keitasuzuki.park@sslab.ics.keio.ac.jp>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200908121743.23108-1-keitasuzuki.park@sslab.ics.keio.ac.jp
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c