percpu: fix spurious sparse warnings from DEFINE_PER_CPU()
authorTejun Heo <tj@kernel.org>
Wed, 4 Dec 2013 15:12:40 +0000 (10:12 -0500)
committerTejun Heo <tj@kernel.org>
Thu, 5 Dec 2013 17:59:23 +0000 (12:59 -0500)
commitb1a0fbfdde65dffd83c84c006f84fa12041907c5
tree5abf835511af7cc259b15b616bb9592eb2e19bd3
parent6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae
percpu: fix spurious sparse warnings from DEFINE_PER_CPU()

When CONFIG_DEBUG_FORCE_WEAK_PER_CPU or CONFIG_ARCH_NEEDS_WEAK_PER_CPU
is set, DEFINE_PER_CPU() explodes into cryptic series of definitions
to still allow using "static" for percpu variables while keeping all
per-cpu symbols unique in the kernel image which is required for weak
symbols.  This ultimately converts the actual symbol to global whether
DEFINE_PER_CPU() is prefixed with static or not.

Unfortunately, the macro forgot to add explicit extern declartion of
the actual symbol ending up defining global symbol without preceding
declaration for static definitions which naturally don't have matching
DECLARE_PER_CPU().  The only ill effect is triggering of the following
warnings.

 fs/inode.c:74:8: warning: symbol 'nr_inodes' was not declared. Should it be static?
 fs/inode.c:75:8: warning: symbol 'nr_unused' was not declared. Should it be static?

Fix it by adding extern declaration in the DEFINE_PER_CPU() macro.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Tested-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
include/linux/percpu-defs.h