bfd_get_filename
authorAlan Modra <amodra@gmail.com>
Fri, 6 Sep 2019 02:37:05 +0000 (12:07 +0930)
committerAlan Modra <amodra@gmail.com>
Fri, 6 Sep 2019 02:52:59 +0000 (12:22 +0930)
commitb16c44debcf8a446e94e161e328169f5c8d5d811
treef402c08e8f7fc00a404055e36c416580377f1b3a
parent6ade8373c9e689dece1057366b5adf9f8e86fa22
bfd_get_filename

This macro says:
/* Cast from const char * to char * so that caller can assign to
   a char * without a warning.  */

I reckon that isn't such a good idea since it can result in char*
variables where const char* is appropriate.  Not very many places
need the char* cast.

bfd/
* aout-target.h (object_p): Formatting.
* bfd-in.h (bfd_get_filename): Don't cast to char*.
* corefile.c (generic_core_file_matches_executable_p): Constify
variables and remove cast.
* bfd-in2.h: Regenerate.
binutils/
* nm.c (print_object_filename_bsd, print_object_filename_sysv),
(print_object_filename_posix, print_archive_filename_bsd),
(print_archive_filename_sysv, print_archive_filename_posix),
(print_archive_member_bsd, print_archive_member_sysv),
(print_archive_member_posix): Constify parameter.
(struct output_fns <print_object_filename, print_archive_filename>),
(<print_archive_member>): Likewise.
* objcopy.c (copy_archive): Add cast for make_tempdir.
ld/
* emultempl/elf32.em (gld${EMULATION_NAME}_search_needed): Constify
variable.
* emultempl/pe.em (gld_${EMULATION_NAME}_after_open): Likewise.
* emultempl/pep.em (gld_${EMULATION_NAME}_after_open): Likewise.
gdb/
* coffread.c (coff_symfile_read): Constify filename variable.
* dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
(elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
* gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
* solib.c (reload_shared_libraries_1): Likewise.
* symfile.c (reread_symbols): Likewise.
* solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
* solib-darwin.c (darwin_bfd_open): Likewise.
* symfile-mem.c (symbol_file_add_from_memory): Likewise.
sim/cris/
* sim-if.c (sim_open): Constify filename variable.
23 files changed:
bfd/ChangeLog
bfd/aout-target.h
bfd/bfd-in.h
bfd/bfd-in2.h
bfd/corefile.c
binutils/ChangeLog
binutils/nm.c
binutils/objcopy.c
gdb/ChangeLog
gdb/coffread.c
gdb/dbxread.c
gdb/gdb_bfd.c
gdb/solib-aix.c
gdb/solib-darwin.c
gdb/solib.c
gdb/symfile-mem.c
gdb/symfile.c
ld/ChangeLog
ld/emultempl/elf32.em
ld/emultempl/pe.em
ld/emultempl/pep.em
sim/cris/ChangeLog
sim/cris/sim-if.c