Revert "Revert[2] "clean up (partially) colortable api"""
authorMike Reed <reed@google.com>
Sat, 1 Apr 2017 17:21:42 +0000 (17:21 +0000)
committerSkia Commit-Bot <skia-commit-bot@chromium.org>
Sat, 1 Apr 2017 17:21:52 +0000 (17:21 +0000)
commitb14131c1851eea6acbd34cc42a8f860daed36b21
tree39e74b29ec1a34ff63fc347ba9b616186f435ff6
parent9920b10f5292838f00600f676c4578cd11705e60
Revert "Revert[2] "clean up (partially) colortable api"""

This reverts commit 9920b10f5292838f00600f676c4578cd11705e60.

Reason for revert: trying to get details on w2k failure

https://chromium-swarm.appspot.com/task?id=354345d34ba3b310&refresh=10

Caught exception 3221225477 EXCEPTION_ACCESS_VIOLATION, was running:
unit test  HugeBlurImageFilter
unit test  FontNames
unit test  Codec_PngRoundTrip
unit test  ClampRange
unit test  FontHost
unit test  ColorMatrixFilter
f16 image scaled_codec_premul abnormal.wbmp
565 image brd_android_codec_divisor_0.167 interlaced3.png_0.167
unit test  Codec_png
unit test  ImageFilterBlurLargeImage
unit test  FontObj
unit test  DrawText
unit test  GrShape
565 image brd_android_codec_divisor_0.333 interlaced2.png_0.333
unit test  PathOpsOpCubicsThreaded
unit test  PathOpsOpLoopsThreaded
unit test  FontMgr
unit test  ColorToHSVRoundTrip
unit test  Image_Serialize_Encoding_Failure
Likely culprit:
unit test  Image_Serialize_Encoding_Failure
step returned non-zero exit code: -1073741819

Original change's description:
> Revert[2] "clean up (partially) colortable api""
>
> This reverts commit 1d1165ca6575e082b892c5460492c411618783ad.
>
> Bug: skia:
> Change-Id: Idbc0634ae3cec2e79f592d252de8751b077e6408
> Reviewed-on: https://skia-review.googlesource.com/11024
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>
>

TBR=reed@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: Ia4e73434b083224baa36092c69526c2f59bb16aa
Reviewed-on: https://skia-review.googlesource.com/11025
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
37 files changed:
bench/BitmapBench.cpp
bench/RepeatTileBench.cpp
dm/DMSrcSink.cpp
fuzz/fuzz.cpp
gm/all_bitmap_configs.cpp
gm/bitmapfilters.cpp
gm/encode-srgb.cpp
gm/image_pict.cpp
gm/tinybitmap.cpp
gn/android_framework_defines.gni
include/core/SkBitmap.h
include/core/SkColorTable.h
include/core/SkMallocPixelRef.h
public.bzl
samplecode/SampleBlur.cpp
samplecode/SampleDitherBitmap.cpp
samplecode/SampleFilter.cpp
samplecode/SampleTinyBitmap.cpp
src/core/SkBitmap.cpp
src/core/SkBitmapDevice.cpp
src/core/SkColorTable.cpp
src/core/SkImageCacherator.cpp
src/core/SkMallocPixelRef.cpp
src/core/SkSpecialSurface.cpp
src/effects/gradients/SkGradientShader.cpp
src/effects/gradients/SkGradientShaderPriv.h
src/image/SkSurface_Raster.cpp
tests/BitmapCopyTest.cpp
tests/BitmapTest.cpp
tests/CodecPriv.h
tests/CodecTest.cpp
tests/GifTest.cpp
tests/ImageTest.cpp
tests/MallocPixelRefTest.cpp
tests/PixelRefTest.cpp
tests/WritePixelsTest.cpp
tools/Resources.cpp