Revert "Revert "Revert "[analyzer] NFC: Move path diagnostic consumer implementations...
authorDavid Blaikie <dblaikie@gmail.com>
Fri, 8 Jan 2021 01:01:17 +0000 (17:01 -0800)
committerDavid Blaikie <dblaikie@gmail.com>
Fri, 8 Jan 2021 02:18:23 +0000 (18:18 -0800)
commitb12f26733a4259c90e5f387aceb9f23c35e003b8
tree6cbb6209c5774936cff2916eaff5cbae5d2881c7
parent658a1be76ba2e9880bc1dd530869a45be452344c
Revert "Revert "Revert "[analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis."""

This reverts commit d2ddc694ff94743d9735aaf07edcaf6db8aaca04.

This still contains a circular dependency between Analysis and CrossTU:

$ grep -r include.*Analysis clang/include/clang/CrossTU
clang/include/clang/CrossTU/CrossTranslationUnit.h:
  #include "clang/Analysis/CrossTUAnalysisHelper.h"
$ grep -r include.*CrossTU clang/lib/Analysis
clang/lib/Analysis/PlistHTMLPathDiagnosticConsumer.cpp:
  #include "clang/CrossTU/CrossTranslationUnit.h"
clang/lib/Analysis/PlistPathDiagnosticConsumer.cpp:
  #include "clang/Analysis/CrossTUAnalysisHelper.h"
18 files changed:
clang/include/clang/Analysis/CrossTUAnalysisHelper.h [deleted file]
clang/include/clang/Analysis/PathDiagnosticConsumers.def [deleted file]
clang/include/clang/CrossTU/CrossTranslationUnit.h
clang/include/clang/StaticAnalyzer/Core/Analyses.def
clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
clang/include/clang/StaticAnalyzer/Core/PathDiagnosticConsumers.h [moved from clang/include/clang/Analysis/PathDiagnosticConsumers.h with 78% similarity]
clang/include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h
clang/include/clang/module.modulemap
clang/lib/Analysis/CMakeLists.txt
clang/lib/Analysis/PlistHTMLPathDiagnosticConsumer.cpp [deleted file]
clang/lib/CrossTU/CrossTranslationUnit.cpp
clang/lib/Frontend/CompilerInvocation.cpp
clang/lib/StaticAnalyzer/Core/CMakeLists.txt
clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp [moved from clang/lib/Analysis/HTMLPathDiagnosticConsumer.cpp with 91% similarity]
clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp [moved from clang/lib/Analysis/PlistPathDiagnosticConsumer.cpp with 96% similarity]
clang/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp [moved from clang/lib/Analysis/SarifPathDiagnosticConsumer.cpp with 93% similarity]
clang/lib/StaticAnalyzer/Core/TextDiagnostics.cpp [moved from clang/lib/Analysis/TextPathDiagnosticConsumer.cpp with 79% similarity]
clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp