ext4: avoid drop reference to iloc.bh twice
authorPan Bian <bianpan2016@163.com>
Thu, 25 Apr 2019 15:44:15 +0000 (11:44 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 May 2019 05:37:42 +0000 (07:37 +0200)
commitb12a8d80a46e8ab02eb9124a36562a93bbd7224b
tree6e83c398d0b14520905173010e878a7474cdf551
parentf0f805f8b9e72be1d77bc1cc6f85eab0c3fd637a
ext4: avoid drop reference to iloc.bh twice

commit 8c380ab4b7b59c0c602743810be1b712514eaebc upstream.

The reference to iloc.bh has been dropped in ext4_mark_iloc_dirty.
However, the reference is dropped again if error occurs during
ext4_handle_dirty_metadata, which may result in use-after-free bugs.

Fixes: fb265c9cb49e("ext4: add ext4_sb_bread() to disambiguate ENOMEM cases")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Jan Kara <jack@suse.cz>
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext4/resize.c