gpio: pca953x: Fix pca953x_gpio_set_pull_up_down()
authorMartyn Welch <martyn.welch@collabora.com>
Wed, 14 Sep 2022 15:15:55 +0000 (16:15 +0100)
committerBartosz Golaszewski <brgl@bgdev.pl>
Thu, 15 Sep 2022 08:08:44 +0000 (10:08 +0200)
commitb122624ab91705d30354f0397b1eea931c6b1933
treeb6fdfb7a16eaba09bb0862d1990b9ca7b0889e7e
parent9f7fed73072e34b123f8c856ae21a2154c0e9781
gpio: pca953x: Fix pca953x_gpio_set_pull_up_down()

A previous fix, commit dc87f6dd058a ("gpio: pca953x: Fix
pca953x_gpio_set_config"), identified that pinconf_to_config_param() needed
to be used to isolate the config_param from the pinconf in
pca953x_gpio_set_config(). This fix however did not consider that this
would also be needed in pca953x_gpio_set_pull_up_down() to which it passes
this config.

Perform a similar call in pca953x_gpio_set_pull_up_down() to isolate the
configuration parameter there as well, rather than passing it from
pca953x_gpio_set_config() as the configuration argument may also be needed
in pca953x_gpio_set_pull_up_down() at a later date.

Signed-off-by: Martyn Welch <martyn.welch@collabora.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
drivers/gpio/gpio-pca953x.c