quirks: use basename in a POSIX compliant way
authorGreg V <greg@unrelenting.technology>
Sun, 14 Oct 2018 12:15:15 +0000 (15:15 +0300)
committerGreg V <greg@unrelenting.technology>
Tue, 16 Oct 2018 10:01:02 +0000 (13:01 +0300)
commitb0cd07bf753f7621c75ead1812a7bf97a2e86a55
tree75b66df58447cb614389ffdf645c431e34587083
parent430ede82666b7b689d5f19dde4817f5d28bc14f6
quirks: use basename in a POSIX compliant way

The POSIX version of basename modifies the string (and therefore crashes
on static strings), so use safe_strdup before calling it.

glibc provides a POSIX version when libgen.h is included.
FreeBSD 12 provides a POSIX version when nothing is included, which was
causing a segfault.

Using the POSIX version correctly is the right way to avoid any such issues.
src/quirks.c