projects / platform / kernel / u-boot.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 306b236) | patch
common/xyzModem.c: Do not use hard-coded address for debug buffer
authorAlexandru Gagniuc <alex.g@adaptrum.com>
Tue, 4 Apr 2017 17:42:31 +0000 (10:42 -0700)
committerTom Rini <trini@konsulko.com>
Sat, 8 Apr 2017 13:26:55 +0000 (09:26 -0400)
commitb09ece0836e0267b86f37defec267aa3806cb03a
tree7d3a337c553b4e10f762ee2bf1de4db70bf816e5tree | snapshot
parent306b236bc1e426ff58ea8ddba1c6ad10327de6ffcommit | diff
common/xyzModem.c: Do not use hard-coded address for debug buffer

Under the plethora of #ifdefs, the xyzModem code hid this pearl:
static char *zm_out = (char *) 0x00380000;
This was only enabled when DEBUG is defined, so it's probably why it
went unnoticed for so long. No idea what platform had memory at that
exact location, but the this approach is extremely hacky.
Use a static buffer instead.

Signed-off-by: Alexandru Gagniuc <alex.g@adaptrum.com>
common/xyzModem.c diff | blob | history
Domain: System / Kernel;