dmaengine: idxd: fix calling wq quiesce inside spinlock
authorDave Jiang <dave.jiang@intel.com>
Wed, 17 Nov 2021 17:03:51 +0000 (10:03 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Dec 2021 08:32:38 +0000 (09:32 +0100)
commitb08767936841fc1737a59a02e667b5b90d8155ee
tree10fdc1febde393845d9af8c5b6203e726a366690
parent05d2cc973cf5225fe542494ef4ac1bc2537a1eef
dmaengine: idxd: fix calling wq quiesce inside spinlock

[ Upstream commit fa51b16d05583c7aebbc06330afb50276243d198 ]

Dan reports that smatch has found idxd_wq_quiesce() is being called inside
the idxd->dev_lock. idxd_wq_quiesce() calls wait_for_completion() and
therefore it can sleep. Move the call outside of the spinlock as it does
not need device lock.

Fixes: 5b0c68c473a1 ("dmaengine: idxd: support reporting of halt interrupt")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/163716858508.1721911.15051495873516709923.stgit@djiang5-desk3.ch.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/dma/idxd/irq.c