batman-adv: Fix multicast TT issues with bogus ROAM flags
authorLinus Lüssing <linus.luessing@c0d3.blue>
Mon, 16 Mar 2020 22:31:00 +0000 (23:31 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 20 Mar 2020 08:07:54 +0000 (09:07 +0100)
commitb081203732b8a12ea7700eeeb8e03e206088bb99
tree6e606533c2343d21b8ea963d48cd14fd103da9b2
parent292ddcd9d68e0a1b52bc15175f43bb122556c2b9
batman-adv: Fix multicast TT issues with bogus ROAM flags

commit a44ebeff6bbd6ef50db41b4195fca87b21aefd20 upstream.

When a (broken) node wrongly sends multicast TT entries with a ROAM
flag then this causes any receiving node to drop all entries for the
same multicast MAC address announced by other nodes, leading to
packet loss.

Fix this DoS vector by only storing TT sync flags. For multicast TT
non-sync'ing flag bits like ROAM are unused so far anyway.

Fixes: 1d8ab8d3c176 ("batman-adv: Modified forwarding behaviour for multicast packets")
Reported-by: Leonardo Mörlein <me@irrelefant.net>
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/batman-adv/translation-table.c