media: camss: Fix signedness bug in video_enum_fmt()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 9 Dec 2020 06:50:34 +0000 (07:50 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 12 Jan 2021 17:14:48 +0000 (18:14 +0100)
commitb00481bdca2d77fdae5f71517c09fd3b30eba57d
tree3f7149fec190eab7c60b2ac768096db5aa9e8e6e
parenta819678d0dcc3cec41a5fd6d359ce5e86f5c58be
media: camss: Fix signedness bug in video_enum_fmt()

This test has a problem because we want to know if "k" is -1 or a
positive value less than "f->index".  But the "f->index" variable is a
u32 so if "k == -1" then -1 gets type promoted to UINT_MAX which is
larger than "f->index".  I've added an explicit test to check for -1.

Fixes: a3d412d4b9f3 ("media: Revert "media: camss: Make use of V4L2_CAP_IO_MC"")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Reviewed-by: Andrey Konovalov <andrey.konovalov@linaro.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/qcom/camss/camss-video.c