RDMA/irdma: avoid fortify-string warning in irdma_clr_wqes
authorArnd Bergmann <arnd@arndb.de>
Tue, 23 May 2023 11:18:45 +0000 (13:18 +0200)
committerJason Gunthorpe <jgg@nvidia.com>
Thu, 1 Jun 2023 15:59:12 +0000 (12:59 -0300)
commitb002760f877c0d91ecd3c78565b52f4bbac379dd
tree171f07d77f768c80b5d3febd07b1b5bcc77ccf6e
parent2145328515c8fa9b8a9f7889250bc6c032f2a0e6
RDMA/irdma: avoid fortify-string warning in irdma_clr_wqes

Commit df8fc4e934c1 ("kbuild: Enable -fstrict-flex-arrays=3") triggers a
warning for fortified memset():

In function 'fortify_memset_chk',
    inlined from 'irdma_clr_wqes' at drivers/infiniband/hw/irdma/uk.c:103:4:
include/linux/fortify-string.h:493:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning]
  493 |                         __write_overflow_field(p_size_field, size);
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The problem here isthat the inner array only has four 8-byte elements, so
clearing 4096 bytes overflows that. As this structure is part of an outer
array, change the code to pass a pointer to the irdma_qp_quanta instead,
and change the size argument for readability, matching the comment above
it.

Fixes: 551c46edc769 ("RDMA/irdma: Add user/kernel shared libraries")
Link: https://lore.kernel.org/r/20230523111859.2197825-1-arnd@kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/irdma/uk.c