HID: pidff: Fix initialisation forMicrosoft Sidewinder FF Pro 2
authorJim Keir <jimkeir@oracledbadirect.com>
Fri, 23 Jan 2015 17:21:12 +0000 (17:21 +0000)
committerJiri Kosina <jkosina@suse.cz>
Mon, 26 Jan 2015 20:26:30 +0000 (21:26 +0100)
commitafd700d933963d07391e3e3dfbfbc05e905960ef
tree063934f6d0e4467c70a50da8766b4868a429926a
parent3458e4c0e5f8783ae699e1205062d1fdd2a48cca
HID: pidff: Fix initialisation forMicrosoft Sidewinder FF Pro 2

The FF2 driver (usbhid/hid-pidff.c) sends commands to the stick during ff_init.
However, this is called inside a block where driver_input_lock is locked, so
the results of these initial commands are discarded. This behavior is the
"killer", without this nothing else works.

ff_init issues commands using "hid_hw_request". This eventually goes to
hid_input_report, which returns -EBUSY because driver_input_lock is locked. The
change is to delay the ff_init call in hid-core.c until after this lock has
been released.

Calling hid_device_io_start() releases the lock so the device can be
configured.  We also need to call hid_device_io_stop() on exit for the lock to
remain locked while ending the init of the drivers.

[ benjamin.tissoires@redhat.com: imrpoved the changelog a lot ]

Signed-off-by: Jim Keir <jimkeir@oracledbadirect.com>
Reviewed-by: Benjamin.tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/usbhid/hid-pidff.c