KVM: x86: MMU: Remove is_rmap_spte() and use is_shadow_present_pte()
authorTakuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>
Fri, 20 Nov 2015 08:44:55 +0000 (17:44 +0900)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 25 Nov 2015 16:26:35 +0000 (17:26 +0100)
commitafd28fe1c901429eba8957f54bdb4a13cc15ae44
tree7255afd192ca75ebb7825aca038d0acf43c120c3
parent029499b477389f7d6486c8c759a8498bcfecf322
KVM: x86: MMU: Remove is_rmap_spte() and use is_shadow_present_pte()

is_rmap_spte(), originally named is_rmap_pte(), was introduced when the
simple reverse mapping was implemented by commit cd4a4e5374110444
("[PATCH] KVM: MMU: Implement simple reverse mapping").  At that point,
its role was clear and only rmap_add() and rmap_remove() were using it
to select sptes that need to be reverse-mapped.

Independently of that, is_shadow_present_pte() was first introduced by
commit c7addb902054195b ("KVM: Allow not-present guest page faults to
bypass kvm") to do bypass_guest_pf optimization, which does not exist
any more.

These two seem to have changed their roles somewhat, and is_rmap_spte()
just calls is_shadow_present_pte() now.

Since using both of them without clear distinction just makes the code
confusing, remove is_rmap_spte().

Signed-off-by: Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/mmu.c
arch/x86/kvm/mmu_audit.c