openvswitch: Avoid OOB read when parsing flow nlattrs
authorRoss Lagerwall <ross.lagerwall@citrix.com>
Mon, 14 Jan 2019 09:16:56 +0000 (09:16 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 6 Feb 2019 16:34:51 +0000 (17:34 +0100)
commitaf9ab785576527aa4fbcfef6f33846068755cabd
tree076385a67200a4226f7bd6ee6cf18ec8fb16dfac
parent4c35624dcb3bce026bb08eb04085c187bafff863
openvswitch: Avoid OOB read when parsing flow nlattrs

[ Upstream commit 04a4af334b971814eedf4e4a413343ad3287d9a9 ]

For nested and variable attributes, the expected length of an attribute
is not known and marked by a negative number.  This results in an OOB
read when the expected length is later used to check if the attribute is
all zeros. Fix this by using the actual length of the attribute rather
than the expected length.

Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Acked-by: Pravin B Shelar <pshelar@ovn.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/openvswitch/flow_netlink.c