drm/i915: Fix bug in user proto-context creation that leaked contexts
authorMatthew Brost <matthew.brost@intel.com>
Fri, 1 Oct 2021 15:58:25 +0000 (08:58 -0700)
committerJani Nikula <jani.nikula@intel.com>
Wed, 13 Oct 2021 10:41:16 +0000 (13:41 +0300)
commitaf628cdd64e11f03181a5a19645768ed4687bda4
tree5a911ba4c9bd9a5115fb976230d64340b75d8965
parente02083f0bcc250c0556ec9e6f7ddb74220c72572
drm/i915: Fix bug in user proto-context creation that leaked contexts

Set number of engines before attempting to create contexts so the
function free_engines can clean up properly. Also check return of
alloc_engines for NULL.

v2:
 (Tvrtko)
  - Send as stand alone patch
 (John Harrison)
  - Check for alloc_engines returning NULL
v3:
 (Checkpatch / Tvrtko)
  - Remove braces around single line if statement

Cc: Jason Ekstrand <jason@jlekstrand.net>
Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to handle create parameters (v5)")
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211001155825.6762-1-matthew.brost@intel.com
(cherry picked from commit 84edf53776343d6b5bf5fa59a6f600a22ca23c40)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/gem/i915_gem_context.c