[flang] Emit errors and warnings about DIM= arguments to intrinsic functions
authorPeter Klausler <pklausler@nvidia.com>
Wed, 16 Nov 2022 21:48:45 +0000 (13:48 -0800)
committerPeter Klausler <pklausler@nvidia.com>
Sun, 4 Dec 2022 21:04:36 +0000 (13:04 -0800)
commitaf54b676e4712e81216eea66e92baa7ffba19a46
treeb8acf6fc886d81d1b201928586e43d6ae73856f3
parent4e62072ca1ee4ecb7584ba9a69464ba617eaae61
[flang] Emit errors and warnings about DIM= arguments to intrinsic functions

The semantics of many transformational intrinsic functions, especially
reductions like SUM(), are determined by the static presence or absence
of a DIM= argument.  In the case of an actual DIM= argument that is
syntactically present but could be dynamically absent at execution time
(due to being OPTIONAL, POINTER, or ALLOCATABLE), f18 should emit some
kind of diagnostic message.

Other compilers either ignore this possibility or treat it as a hard
error; neither really seems correct, so let's do something more nuanced.

For cases where the dynamic absence of a value for DIM doesn't pose
as much of a risk because it lowering is going to assume that it's
equal to 1 anyway, emit only a portability warning.

For other cases where the generated code or runtime support library
will need the value of DIM= during execution, emit a warning that
the use of an OPTIONAL/POINTER/ALLOCATABLE variable or component
here is dicey and should be reconsidered.

While here, also catch bad constant DIM= values.

Differential Revision: https://reviews.llvm.org/D139155
flang/include/flang/Evaluate/fold.h
flang/include/flang/Evaluate/tools.h
flang/lib/Evaluate/fold-implementation.h
flang/lib/Evaluate/fold-integer.cpp
flang/lib/Evaluate/fold.cpp
flang/lib/Evaluate/intrinsics.cpp
flang/lib/Evaluate/tools.cpp
flang/test/Lower/transformational-intrinsics.f90
flang/test/Semantics/dim01.f90 [new file with mode: 0644]