Disable -Wformat-nonliteral in parts of printcmd.c
authorSimon Marchi <simon.marchi@ericsson.com>
Thu, 6 Sep 2018 03:21:51 +0000 (21:21 -0600)
committerTom Tromey <tom@tromey.com>
Thu, 6 Sep 2018 03:47:33 +0000 (21:47 -0600)
commitaf39b1c216ffb11e6ca8e8607b00749e0fc1ab41
tree2c1e035ca006f6e98e6b9d844f3139ad386b9d21
parent4f075c06a3adbccdc2712c3e24afc7d4814149c7
Disable -Wformat-nonliteral in parts of printcmd.c

commit 3322c5d9a1 ("Remove unneeded explicit .o targets") broke the
build with clang, because -Wno-format-nonliteral was in fact needed.
This patch fixes the problem by introducing
DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL and using it in printcmd.c.  This
seems preferable to reverting the patch because now the warning
suppression is more targeted.

gdb/ChangeLog
2018-09-05  Simon Marchi  <simon.marchi@ericsson.com>

* printcmd.c (printf_c_string): Use
DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL.
(printf_wide_c_string, printf_pointer, ui_printf): Likewise.

include/ChangeLog
2018-09-05  Simon Marchi  <simon.marchi@ericsson.com>

* diagnostics.h (DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL): New macro.
gdb/ChangeLog
gdb/printcmd.c
include/ChangeLog
include/diagnostics.h