[RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values
authorFangrui Song <i@maskray.me>
Wed, 8 Feb 2023 01:13:21 +0000 (17:13 -0800)
committerFangrui Song <i@maskray.me>
Wed, 8 Feb 2023 01:13:21 +0000 (17:13 -0800)
commitaf128791464810123bcd60a6d9d0902b5c550aef
treee6c45672282667302925548da74674b14b23640d
parent9aa00c8a306561c4e3ddb09058e66bae322a0769
[RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

Fix an issue about module linking with LTO.

When compiling with PIE, the small data limitation needs to be consistent with that in PIC, otherwise there will be linking errors due to conflicting values.

bar.c
```
int bar() { return 1; }
```

foo.c
```
int foo() { return 1; }
```

```
clang --target=riscv64-unknown-linux-gnu -flto -c foo.c -o foo.o -fPIE
clang --target=riscv64-unknown-linux-gnu -flto -c bar.c -o bar.o -fPIC

clang --target=riscv64-unknown-linux-gnu -flto foo.o bar.o -flto -nostdlib -v -fuse-ld=lld
```

```
ld.lld: error: linking module flags 'SmallDataLimit': IDs have conflicting values in 'bar.o' and 'ld-temp.o'
clang-15: error: linker command failed with exit code 1 (use -v to see invocation)
```

Use Min instead of Error for conflicting SmallDataLimit.

Authored by: @joshua-arch1
Signed-off-by: xiaojing.zhang <xiaojing.zhang@xcalibyte.com>
Signed-off-by: jianxin.lai <jianxin.lai@xcalibyte.com>
Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D131230
clang/lib/CodeGen/CodeGenModule.cpp
clang/test/CodeGen/RISCV/riscv-sdata-module-flag.c
clang/test/CodeGen/RISCV/rvv-intrinsics-handcrafted/vlenb.c
llvm/test/CodeGen/RISCV/sdata-limit-0.ll
llvm/test/CodeGen/RISCV/sdata-limit-4.ll
llvm/test/CodeGen/RISCV/sdata-limit-8.ll
llvm/test/CodeGen/RISCV/sdata-local-sym.ll
llvm/test/Transforms/LoopVectorize/RISCV/riscv-interleaved.ll