xfs: move local to extent inode logging into bmap helper
authorBrian Foster <bfoster@redhat.com>
Mon, 7 Oct 2019 19:54:16 +0000 (12:54 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Wed, 9 Oct 2019 15:54:30 +0000 (08:54 -0700)
commitaeea4b75f045294e1c026acc380466daa43afc65
treecb1ea331f4b4d12b4467f8518d774ddb260ecb00
parent603efebd6768356fb7cea02e4a822587c2dc5d7c
xfs: move local to extent inode logging into bmap helper

The callers of xfs_bmap_local_to_extents_empty() log the inode
external to the function, yet this function is where the on-disk
format value is updated. Push the inode logging down into the
function itself to help prevent future mistakes.

Note that internal bmap callers track the inode logging flags
independently and thus may log the inode core twice due to this
change. This is harmless, so leave this code around for consistency
with the other attr fork conversion functions.

Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/libxfs/xfs_attr_leaf.c
fs/xfs/libxfs/xfs_bmap.c
fs/xfs/libxfs/xfs_bmap.h
fs/xfs/libxfs/xfs_dir2_block.c