sch_htb: fix null pointer dereference on a null new_q
authorYunjian Wang <wangyunjian@huawei.com>
Tue, 30 Mar 2021 14:27:48 +0000 (22:27 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 30 Mar 2021 20:50:03 +0000 (13:50 -0700)
commitae81feb7338c89cee4e6aa0424bdab2ce2b52da2
tree810bf9f3858b8e2d39947896cad979dc248daab9
parent8a03dd925786bdc3834d56ccc980bb70668efa35
sch_htb: fix null pointer dereference on a null new_q

sch_htb: fix null pointer dereference on a null new_q

Currently if new_q is null, the null new_q pointer will be
dereference when 'q->offload' is true. Fix this by adding
a braces around htb_parent_to_leaf_offload() to avoid it.

Addresses-Coverity: ("Dereference after null check")
Fixes: d03b195b5aa0 ("sch_htb: Hierarchical QoS hardware offload")

Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_htb.c