projects / platform / upstream / systemd.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 0c1792e) | patch
basic/terminal-util: cache value for colors_enabled
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Wed, 20 Apr 2016 01:30:14 +0000 (21:30 -0400)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Wed, 20 Apr 2016 12:58:53 +0000 (08:58 -0400)
commitae5b39588734aacef5b6b411cf2053fdcef4764a
tree27eeddf1f641a5f71690e4e4bcc99d43c2e504aatree | snapshot
parent0c1792efe422622c3c8a11b70a722147304da4cbcommit | diff
basic/terminal-util: cache value for colors_enabled

After all it's something that we query over and over.
For example, systemctl calls colors_enabled() four times for each failing
service. The compiler is unable to optimize those calls away because they
(potentially) accesses external and global state through on_tty() and
getenv().
src/basic/terminal-util.c diff | blob | history
Domain: System / System Framework;