net: hisilicon: fix the return value handle and remove redundant netdev_err() for...
authorRuan Jinjie <ruanjinjie@huawei.com>
Mon, 31 Jul 2023 07:38:58 +0000 (15:38 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 2 Aug 2023 19:06:23 +0000 (12:06 -0700)
commitae1d60c41e581be049aa84dd53aca89027101ce1
treed4005b359c0b6b1116ff8cf8aed332b229a89223
parent34093c9fa05df24558d1e2c5d32f7f93b2c97ee9
net: hisilicon: fix the return value handle and remove redundant netdev_err() for platform_get_irq()

There is no possible for platform_get_irq() to return 0
and the return value of platform_get_irq() is more sensible
to show the error reason.

And there is no need to call the netdev_err() function directly to print
a custom message when handling an error from platform_get_irq() function as
it is going to display an appropriate error message in case of a failure.

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20230731073858.3633193-1-ruanjinjie@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/hisilicon/hip04_eth.c
drivers/net/ethernet/hisilicon/hisi_femac.c
drivers/net/ethernet/hisilicon/hix5hd2_gmac.c