fanotify: fix copy_event_to_user() fid error clean up
authorMatthew Bobrowski <repnop@google.com>
Fri, 11 Jun 2021 03:32:06 +0000 (13:32 +1000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 23 Jun 2021 12:42:41 +0000 (14:42 +0200)
commitae1d3b989d19e4d8d4fee612a4d24ef992fcd25f
tree0d83361ebf013bd8ddaae0982f42b8c0fbdfa124
parent018685461a5b9a9a70e664ac77aef0d7415a3fd5
fanotify: fix copy_event_to_user() fid error clean up

[ Upstream commit f644bc449b37cc32d3ce7b36a88073873aa21bd5 ]

Ensure that clean up is performed on the allocated file descriptor and
struct file object in the event that an error is encountered while copying
fid info objects. Currently, we return directly to the caller when an error
is experienced in the fid info copying helper, which isn't ideal given that
the listener process could be left with a dangling file descriptor in their
fdtable.

Fixes: 5e469c830fdb ("fanotify: copy event fid info to user")
Fixes: 44d705b0370b ("fanotify: report name info for FAN_DIR_MODIFY event")
Link: https://lore.kernel.org/linux-fsdevel/YMKv1U7tNPK955ho@google.com/T/#m15361cd6399dad4396aad650de25dbf6b312288e
Link: https://lore.kernel.org/r/1ef8ae9100101eb1a91763c516c2e9a3a3b112bd.1623376346.git.repnop@google.com
Signed-off-by: Matthew Bobrowski <repnop@google.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/notify/fanotify/fanotify_user.c