bonding: require speed/duplex only for 802.3ad, alb and tlb
authorAndreas Born <futur.andy@googlemail.com>
Thu, 10 Aug 2017 04:41:44 +0000 (06:41 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 16 Jun 2018 07:52:32 +0000 (09:52 +0200)
commitae0c8eeb66045ea2e327b23d21788622ca510627
tree4c22e6b761e9edf189045b180fc1a4b88522f6be
parentbc5ad405837a9e89595cd603a8d329ec9d96dde9
bonding: require speed/duplex only for 802.3ad, alb and tlb

commit ad729bc9acfb7c47112964b4877ef5404578ed13 upstream.

The patch c4adfc822bf5 ("bonding: make speed, duplex setting consistent
with link state") puts the link state to down if
bond_update_speed_duplex() cannot retrieve speed and duplex settings.
Assumably the patch was written with 802.3ad mode in mind which relies
on link speed/duplex settings. For other modes like active-backup these
settings are not required. Thus, only for these other modes, this patch
reintroduces support for slaves that do not support reporting speed or
duplex such as wireless devices. This fixes the regression reported in
bug 196547 (https://bugzilla.kernel.org/show_bug.cgi?id=196547).

Fixes: c4adfc822bf5 ("bonding: make speed, duplex setting consistent
with link state")
Signed-off-by: Andreas Born <futur.andy@googlemail.com>
Acked-by: Mahesh Bandewar <maheshb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Cc: Nate Clark <nate@neworld.us>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/bonding/bond_main.c
include/net/bonding.h