jbd2: Fix possible overflow in jbd2_log_space_left()
authorJan Kara <jack@suse.cz>
Tue, 5 Nov 2019 16:44:07 +0000 (17:44 +0100)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 5 Nov 2019 17:13:25 +0000 (12:13 -0500)
commitadd3efdd78b8a0478ce423bb9d4df6bd95e8b335
tree0555cd095901cba4a4a91e86d58eaf459e9f2c51
parent4f5cafb5cb8471e54afdc9054d973535614f7675
jbd2: Fix possible overflow in jbd2_log_space_left()

When number of free space in the journal is very low, the arithmetic in
jbd2_log_space_left() could underflow resulting in very high number of
free blocks and thus triggering assertion failure in transaction commit
code complaining there's not enough space in the journal:

J_ASSERT(journal->j_free > 1);

Properly check for the low number of free blocks.

CC: stable@vger.kernel.org
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20191105164437.32602-1-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
include/linux/jbd2.h