c++: Relax attribute on friend declaration checking [PR100596]
authorMarek Polacek <polacek@redhat.com>
Tue, 18 May 2021 20:11:16 +0000 (16:11 -0400)
committerMarek Polacek <polacek@redhat.com>
Wed, 19 May 2021 17:10:15 +0000 (13:10 -0400)
commitadcb497bdba499d161d2e5e8de782bdd6f75d62c
treea942fb6dd1ff181d3f39e0507b46db9045f88a9d
parenta911287e13d1a1f95259cb60c57293eabc2a27b9
c++: Relax attribute on friend declaration checking [PR100596]

It turned out that there are codebases that profusely use GNU attributes
on friend declarations, so we have to dial back our checking and allow
them.  And for C++11 attributes let's just warn instead of giving
errors.

PR c++/100596

gcc/cp/ChangeLog:

* cp-tree.h (any_non_type_attribute_p): Remove.
* decl.c (grokdeclarator): Turn an error into a warning and only
warn for standard attributes.
* decl2.c (any_non_type_attribute_p): Remove.
* parser.c (cp_parser_elaborated_type_specifier): Turn an error
into a warning and only warn for standard attributes.
(cp_parser_member_declaration): Likewise.

gcc/testsuite/ChangeLog:

* g++.dg/cpp0x/friend7.C: Turn a few dg-warnings into dg-errors.
Remove dg-errors for GNU attributes.
* g++.dg/ext/attrib63.C: Remove dg-error.
* g++.dg/cpp0x/friend8.C: New test.
gcc/cp/cp-tree.h
gcc/cp/decl.c
gcc/cp/decl2.c
gcc/cp/parser.c
gcc/testsuite/g++.dg/cpp0x/friend7.C
gcc/testsuite/g++.dg/cpp0x/friend8.C [new file with mode: 0644]
gcc/testsuite/g++.dg/ext/attrib63.C