kernfs: Fix range checks in kernfs_get_target_path
authorBernd Edlinger <bernd.edlinger@hotmail.de>
Sat, 7 Jul 2018 17:52:47 +0000 (17:52 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Nov 2019 17:46:47 +0000 (18:46 +0100)
commitada2a0f1ac54fd6625e791a98402b57f24ad5470
treec5608bac3123a8c285d8db1d237f0c98cfbff9ca
parent5fba8151069702486138d05cd96c1713f1720343
kernfs: Fix range checks in kernfs_get_target_path

[ Upstream commit a75e78f21f9ad4b810868c89dbbabcc3931591ca ]

The terminating NUL byte is only there because the buffer is
allocated with kzalloc(PAGE_SIZE, GFP_KERNEL), but since the
range-check is off-by-one, and PAGE_SIZE==PATH_MAX, the
returned string may not be zero-terminated if it is exactly
PATH_MAX characters long.  Furthermore also the initial loop
may theoretically exceed PATH_MAX and cause a fault.

Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/kernfs/symlink.c