bpf, sockhash: Synchronize_rcu before free'ing map
authorJakub Sitnicki <jakub@cloudflare.com>
Thu, 6 Feb 2020 11:16:51 +0000 (12:16 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Feb 2020 07:36:32 +0000 (08:36 +0100)
commitad9728b377a679d2ad9b71c7fdbb28f6c7258292
tree18ba6bf7d7bd1f1b2b2d63b5863c3dcc6a052080
parent25c85d8574d8e4466a6334325a5ab5a3aab3c4c2
bpf, sockhash: Synchronize_rcu before free'ing map

[ Upstream commit 0b2dc83906cf1e694e48003eae5df8fa63f76fd9 ]

We need to have a synchronize_rcu before free'ing the sockhash because any
outstanding psock references will have a pointer to the map and when they
use it, this could trigger a use after free.

This is a sister fix for sockhash, following commit 2bb90e5cc90e ("bpf:
sockmap, synchronize_rcu before free'ing map") which addressed sockmap,
which comes from a manual audit.

Fixes: 604326b41a6fb ("bpf, sockmap: convert to generic sk_msg interface")
Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/bpf/20200206111652.694507-3-jakub@cloudflare.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/core/sock_map.c