octeontx2-af: Fix reference count issue in rvu_sdp_init()
authorXiongfeng Wang <wangxiongfeng2@huawei.com>
Wed, 23 Nov 2022 06:59:19 +0000 (14:59 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 24 Nov 2022 09:01:42 +0000 (10:01 +0100)
commitad17c2a3f11b0f6b122e7842d8f7d9a5fcc7ac63
tree85dc44783eee9395727f06f48f2ae0e8e8d1eb0f
parent6aae1bcb41c7aefd28bf5d90e36ebdd151c2d8ba
octeontx2-af: Fix reference count issue in rvu_sdp_init()

pci_get_device() will decrease the reference count for the *from*
parameter. So we don't need to call put_device() to decrease the
reference. Let's remove the put_device() in the loop and only decrease
the reference count of the returned 'pdev' for the last loop because it
will not be passed to pci_get_device() as input parameter. We don't need
to check if 'pdev' is NULL because it is already checked inside
pci_dev_put(). Also add pci_dev_put() for the error path.

Fixes: fe1939bb2340 ("octeontx2-af: Add SDP interface support")
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Reviewed-by: Saeed Mahameed <saeed@kernel.org>
Link: https://lore.kernel.org/r/20221123065919.31499-1-wangxiongfeng2@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/marvell/octeontx2/af/rvu_sdp.c