dwarf-reader: relax restriction about relocation sections in try_reading_first_ksymta...
authorMatthias Maennich <maennich@google.com>
Wed, 13 Nov 2019 15:09:17 +0000 (15:09 +0000)
committerMatthias Maennich <maennich@google.com>
Tue, 7 Jan 2020 14:47:36 +0000 (14:47 +0000)
commitacfcea3ef28b412636eb2a89237daeb831c27834
tree3143d126eac709931f7a675920fafb5efda3988f
parent189b318caec975875fec13bc03c718773cf34890
dwarf-reader: relax restriction about relocation sections in try_reading_first_ksymtab_entry

Commit 43679a610316 ("dwarf-reader: refactor
try_reading_first_ksymtab_entry_using{pre,}_v4_19_format") introduced an
assertion to ensure the absence of ksymtab relocation sections as they
are an unhandled case for try_reading_first_ksymtab_entry. This
assertion turns out to be too strict as relocation sections might be
present (e.g. on x86_64), but not affecting the functionality of this
function (i.e. helping to detect the ksymtab format). Hence, remove the
assertion and document that case.

* src/abg-dwarf-reader.cc (try_reading_first_ksymtab_entry):
remove assertion and update documentation

Fixes: 43679a610316 ("dwarf-reader: refactor try_reading_first_ksymtab_entry_using{pre,}_v4_19_format")
Reviewed-by: Dodji Seketeli <dodji@seketeli.org>
Signed-off-by: Matthias Maennich <maennich@google.com>
src/abg-dwarf-reader.cc