net: diag: Don't double-free TCP_NEW_SYN_RECV sockets in tcp_abort
authorLorenzo Colitti <lorenzo@google.com>
Sat, 7 Jul 2018 07:31:40 +0000 (16:31 +0900)
committerDavid S. Miller <davem@davemloft.net>
Sun, 8 Jul 2018 01:56:10 +0000 (10:56 +0900)
commitacc2cf4e37174646a24cba42fa53c668b2338d4e
tree70b6f2d1ea8e0b2795660bd2150fc12c481c81dd
parente7372197e15856ec4ee66b668020a662994db103
net: diag: Don't double-free TCP_NEW_SYN_RECV sockets in tcp_abort

When tcp_diag_destroy closes a TCP_NEW_SYN_RECV socket, it first
frees it by calling inet_csk_reqsk_queue_drop_and_and_put in
tcp_abort, and then frees it again by calling sock_gen_put.

Since tcp_abort only has one caller, and all the other codepaths
in tcp_abort don't free the socket, just remove the free in that
function.

Cc: David Ahern <dsa@cumulusnetworks.com>
Tested: passes Android sock_diag_test.py, which exercises this codepath
Fixes: d7226c7a4dd1 ("net: diag: Fix refcnt leak in error path destroying socket")
Signed-off-by: Lorenzo Colitti <lorenzo@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: David Ahern <dsa@cumulusnetworks.com>
Tested-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp.c