[M67 Dev][WRT][EWK] Deprecate ewk_send_widget_info and add ewk_context_tizen_app_id_set 49/187849/2
authoryh106.jung <yh106.jung@samsung.com>
Mon, 5 Dec 2016 23:14:11 +0000 (08:14 +0900)
committerGerrit Code Review <gerrit@review.ap-northeast-2.compute.internal>
Wed, 10 Oct 2018 04:56:29 +0000 (04:56 +0000)
commitacb7037bb16c209666b4b7ef6e8352924e7e80ef
tree9cdea395188f060069a921907def3e8b4fd09681
parentc151bad6caaaebb9d2ca17354ae909039aecceb4
[M67 Dev][WRT][EWK] Deprecate ewk_send_widget_info and add ewk_context_tizen_app_id_set

Original patch: http://165.213.202.130/gerrit/#/c/98860/
Original author: Marcin Niesluchowski <m.niesluchow@samsung.com>

ewk_context_tizen_app_id_set() does the same as ewk_send_widget_info()
but with removal of unnecessary parameters, which are not used in
plugins. Also name has been changed due its inconsistency with
implementation and usage. ewk_send_widget_info() was marked as
deprecated. Fix
utc_blink_ewk_context_new_with_injected_bundle_path_func.POS_TEST1
failing due to ewk_send_widget_info() api called after loading url.
Now ewk_context_tizen_app_id_set() is called before loading url
instead.

To complete api change following steps should be taken:
1) After this commit is merged all plugin libraries should add [1]
and [2] api and remove [3]. [1] api should return current plugin
verison - 1. [2] should act the same as [3] api.
ewk_context_tizen_app_id_set should be used instead of
ewk_send_widget_info.
2) After that ewk_send_widget_info deprecated api should be removed
in different commit.

For proper usage see following test file:
ewk/unittest/resources/ewk_context/injected_bundle/chromium/bundle_sample.cc

[1] unsigned int DynamicPluginVersion();

[2] void DynamicPluginStartSession(const char* tizen_app_id,
                                   v8::Handle<v8::Context> context,
                                   int routing_handle,
                                   const char* base_url);

[3] void DynamicPluginStartSession(const char* tizen_id,
                                   v8::Handle<v8::Context> context,
                                   int routing_handle,
                                   double scale,
                                   const char* encoded_bundle,
                                   const char* theme,
                                   const char* base_url);

Reference:
https://review.tizen.org/gerrit/#/c/173311/

Change-Id: I6acd741bd41dd4c68d1ca8e7e6022ce7a01e5cba
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
18 files changed:
tizen_src/ewk/efl_integration/common/content_switches_efl.cc
tizen_src/ewk/efl_integration/common/content_switches_efl.h
tizen_src/ewk/efl_integration/content_browser_client_efl.cc
tizen_src/ewk/efl_integration/eweb_context.cc
tizen_src/ewk/efl_integration/eweb_context.h
tizen_src/ewk/efl_integration/private/ewk_context_private.cc
tizen_src/ewk/efl_integration/private/ewk_context_private.h
tizen_src/ewk/efl_integration/public/ewk_context.cc
tizen_src/ewk/efl_integration/renderer/content_renderer_client_efl.cc
tizen_src/ewk/efl_integration/wrt/dynamicplugin.cc
tizen_src/ewk/efl_integration/wrt/dynamicplugin.h
tizen_src/ewk/efl_integration/wrt/wrt_file_protocol_handler.cc
tizen_src/ewk/efl_integration/wrt/wrt_widget_host.cc
tizen_src/ewk/efl_integration/wrt/wrt_widget_host.h
tizen_src/ewk/efl_integration/wrt/wrtwidget.cc
tizen_src/ewk/efl_integration/wrt/wrtwidget.h
tizen_src/ewk/unittest/resources/ewk_context/injected_bundle/chromium/bundle_sample.cc
tizen_src/ewk/unittest/utc_blink_ewk_context_new_with_injected_bundle_path_func.cc