shutdown: Don't limit unmount attempts prematurely (#8469)
authorJan Janssen <medhefgo@web.de>
Mon, 19 Mar 2018 09:27:49 +0000 (10:27 +0100)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Mon, 19 Mar 2018 09:27:49 +0000 (18:27 +0900)
commitac9cea5ba30acbf17fd431a4a4092c4dbee23593
tree95bb49b80007aef89f217f6d39e1a31a87219979
parente9ee721abdefc69f581e46bb3b4ed1471f6fd8af
shutdown: Don't limit unmount attempts prematurely (#8469)

Once upon a time shutdown.c didn't have the logic to check whether any
unmount attempts succeeded or not. So instead it kept looping for
a fixed amount and hoped all was right. Nowadays, we do know if we
changed anything during a iteration and also stop looping then, but
we still limit ourselves to FINALIZE_ATTEMPTS.

But, theoretically, we could have such a complicated and nested
setup that would survive that limit, leaving stuff around we
might actually be able to unmount. And we could also end up in a
situation where the extra loop with raised unmount error level could
be skipped too.

So let's just drop the retries logic and rely fully on the changed
flag.
src/core/shutdown.c