ethtool: potential NULL dereference in strset_prepare_data()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 8 Jan 2020 05:42:36 +0000 (08:42 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 9 Jan 2020 00:03:35 +0000 (16:03 -0800)
commitac9c41d5a053e71777e8c2191681358499eff04b
tree05e2c24f5a75c762001bd2efab7fb964fe390dc5
parentd97772dbd7727655aa894f1610e983e73678212e
ethtool: potential NULL dereference in strset_prepare_data()

Smatch complains that the NULL checking isn't done consistently:

    net/ethtool/strset.c:253 strset_prepare_data()
    error: we previously assumed 'dev' could be null (see line 233)

It looks like there is a missing return on this path.

Fixes: 71921690f974 ("ethtool: provide string sets with STRSET_GET request")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ethtool/strset.c