spi: spi-mpc52xx-psc: Remove deprecated create_singlethread_workqueue
authorBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Sat, 2 Jul 2016 08:57:06 +0000 (14:27 +0530)
committerMark Brown <broonie@kernel.org>
Sun, 3 Jul 2016 12:23:25 +0000 (14:23 +0200)
commitac96b737cdec77023bf2ead142a3875174af0c7a
tree47d16d331ec840176b8fdacd0645a5a7d7e991df
parent1a695a905c18548062509178b98bc91e67510864
spi: spi-mpc52xx-psc: Remove deprecated create_singlethread_workqueue

The workqueue "workqueue" has a single work item(&mps->work)
doesn't require ordering. Also, it is not being used on a memory reclaim
path. Hence, the singlethreaded workqueue has been replaced with the use
of system_wq.

System workqueues have been able to handle high level of concurrency
for a long time now and hence it's not required to have a singlethreaded
workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue
created with create_singlethread_workqueue(), system_wq allows multiple
work items to overlap executions even on the same CPU; however, a
per-cpu workqueue doesn't have any CPU locality or global ordering
guarantee unless the target CPU is explicitly specified and thus the
increase of local concurrency shouldn't make any difference.

Work item has been flushed in mpc52xx_psc_spi_of_remove() to ensure that
nothing is pending while disconnecting the driver.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-mpc52xx-psc.c