[Basic] Cleanups in IdentifierInfo following the removal of PTH
authorBruno Ricci <riccibrun@gmail.com>
Wed, 5 Dec 2018 17:16:55 +0000 (17:16 +0000)
committerBruno Ricci <riccibrun@gmail.com>
Wed, 5 Dec 2018 17:16:55 +0000 (17:16 +0000)
commitac52954703bfb56a1d27a0aedc49c17a8c59177d
tree236fde79cc8adfe1771d89096f40a17a8dad9ba8
parent33a448f935286de94f00a631277340b8c471a4c0
[Basic] Cleanups in IdentifierInfo following the removal of PTH

The Entry pointer in IdentifierInfo was only null for IdentifierInfo
created from a PTH. Now that PTH support has been removed we can remove
some PTH specific code in IdentifierInfo::getLength and
IdentifierInfo::getNameStart.

Also make the constructor of IdentifierInfo private to make sure that
they are only created by IdentifierTable, and move it to the header so
that it can be inlined in IdentifierTable::get and IdentifierTable::getOwn.

Differential Revision: https://reviews.llvm.org/D54866

Reviewed By: erichkeane

llvm-svn: 348384
clang/include/clang/Basic/IdentifierTable.h
clang/lib/Basic/IdentifierTable.cpp