regulator: da9063: Use struct_size() in devm_kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 21 Feb 2019 17:57:14 +0000 (11:57 -0600)
committerMark Brown <broonie@kernel.org>
Fri, 22 Feb 2019 15:16:57 +0000 (15:16 +0000)
commitac227fb5bc950cf97b0d50ab7ee2c8aa7cd65441
tree6d1c73bd77dc905db832bbcce8b6e254af626b61
parenta661b1d9936e77a6c07f8ca10e3494932fa5e2c8
regulator: da9063: Use struct_size() in devm_kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

size = sizeof(struct foo) + count * sizeof(struct boo);
instance = alloc(size, GFP_KERNEL)

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = alloc(struct_size(instance, entry, count), GFP_KERNEL)

Notice that, in this case, variable size is not necessary, hence it is
removed.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/da9063-regulator.c