[media] tlg2300: fix checking firmware in poseidon_probe()
authorAlexey Khoroshilov <khoroshilov@ispras.ru>
Mon, 24 Jun 2013 18:57:37 +0000 (15:57 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Fri, 26 Jul 2013 16:28:26 +0000 (13:28 -0300)
commitac22521cb2dc07e0b2193868c647dee5d737f85a
tree0bbcb7f5d52aa0f82698278f2987272bc838064b
parent3333447c6946f8a76548d1599686a2bbd11e9264
[media] tlg2300: fix checking firmware in poseidon_probe()

check_firmware() makes sure firmware is in a device.
It returns zero on success and error code otherwise.
Also it sets down_firmware flag to 1 if downloading occurs.
The only caller poseidon_probe() checks down_firmware flag and
returns 0 without any initialization if it is set.
That looks very strange, so the patch removes down_firmware argument
of check_firmware() and returns error code if check_firmware() fails
in poseidon_probe().
Not tested on real hardware.
Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/usb/tlg2300/pd-main.c