Fixed deopt reasons in TaggedToI.
authorsvenpanne@chromium.org <svenpanne@chromium.org>
Wed, 17 Sep 2014 09:51:17 +0000 (09:51 +0000)
committersvenpanne@chromium.org <svenpanne@chromium.org>
Wed, 17 Sep 2014 09:51:17 +0000 (09:51 +0000)
commitac1b9b11dcc32eacebde5e389c932058feb94138
tree94d799fdae90d38fa9313f2416013d430e672c9f
parentfdcf5f99b2c6b7d4e886e4def318a050abada65c
Fixed deopt reasons in TaggedToI.

Every DeoptimizeIf should be preceded by a RecordComment explaining
the reason. In the long run, the reason should be an argument of
DeoptimizeIf, but we're not there yet.

On x87, things are a bit ugly due to some pushing/popping, so if
somebody feels inclined to improve this: Feel free. Probably the right
approach would be reloading instead of the push/pop horror.

Another thing is our inconsistent handling of the "done" continuation
of deferred code on the various platforms, I made tiny changes on the
way, but this should better be unified somehow, with all those
micro-optimizations removed.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/578583002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23996 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
13 files changed:
src/arm/lithium-codegen-arm.cc
src/arm64/lithium-codegen-arm64.cc
src/ia32/lithium-codegen-ia32.cc
src/ia32/macro-assembler-ia32.cc
src/ia32/macro-assembler-ia32.h
src/mips/lithium-codegen-mips.cc
src/mips64/lithium-codegen-mips64.cc
src/x64/lithium-codegen-x64.cc
src/x64/macro-assembler-x64.cc
src/x64/macro-assembler-x64.h
src/x87/lithium-codegen-x87.cc
src/x87/macro-assembler-x87.cc
src/x87/macro-assembler-x87.h