cifs: eliminate the inode argument from cifs_new_fileinfo
authorJeff Layton <jlayton@redhat.com>
Fri, 15 Oct 2010 19:33:58 +0000 (15:33 -0400)
committerSteve French <sfrench@us.ibm.com>
Mon, 18 Oct 2010 01:04:16 +0000 (01:04 +0000)
commitabfe1eedd682ea0f20e7035445982e6d371a2024
tree70d5fe483cae0f782b8e78ea5c08ef2dbb45c2e7
parentf6a53460e2a105904deeada737b3f878d78517b3
cifs: eliminate the inode argument from cifs_new_fileinfo

It already takes a file pointer. The inode associated with that had damn
well better be the same one we're passing in anyway. Thus, there's no
need for a separate argument here.

Also, get rid of the bogus check for a null pCifsInode pointer. The
CIFS_I macro uses container_of(), and that will virtually never return a
NULL pointer anyway.

Finally, move the setting of the canCache* flags outside of the lock.
Other places in the code don't hold that lock when setting it, so I
assume it's not really needed here either.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Suresh Jayaraman <sjayaraman@suse.de>
Acked-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
fs/cifs/cifsproto.h
fs/cifs/dir.c
fs/cifs/file.c